[GTK3] Override gtk_im_module only if it was set to xim #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ibus/ibus#2331 (comment) "There are two modes to communicate between IBus and GTK applications." - GTK_IM_MODULE=wayland (composer mode - GNOME Wayland default) and GTK_IM_MODULE=ibus (no composer mode). Note that "wayland" im module is another incarnation of ibus. The only thing that was broken for sure is "xim" so override only it under Gnome on X11 to prevent making SWT(and as a result Eclipse) use non-default IM modules and thus exposing different behaviour than other apps.
Contributor
Test Results 539 files ±0 539 suites ±0 32m 5s ⏱️ + 6m 59s For more details on these failures, see this check. Results for commit db5282c. ± Comparison against base commit 536fea8. |
Member
Author
|
Windows problems are irrelevant for this change. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ibus/ibus#2331 (comment) "There are two modes to communicate between IBus and GTK applications."
Note that "wayland" im module is another incarnation of ibus. The only thing that was broken for sure is "xim" so override only it under Gnome on X11 to prevent making SWT(and as a result Eclipse) use non-default IM modules and thus exposing different behaviour than other apps.